Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix velph-selfenergy-generate (issue #28) #29

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Fix velph-selfenergy-generate (issue #28) #29

merged 1 commit into from
Sep 25, 2024

Conversation

atztogo
Copy link
Member

@atztogo atztogo commented Sep 25, 2024

This commit fixes issue #28.

Note that the command name velph-elph has been changed to velph-selfenergy. Previously, self-energy and transport calculations were variants of velph-elph, but they are now considered independent calculation types.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 19.56522% with 37 lines in your changes missing coverage. Please review.

Project coverage is 73.27%. Comparing base (79725c8) to head (2c84432).
Report is 25 commits behind head on develop.

Files with missing lines Patch % Lines
src/phelel/velph/cli/selfenergy/generate.py 5.55% 17 Missing ⚠️
src/phelel/velph/cli/hints/__init__.py 0.00% 16 Missing ⚠️
src/phelel/velph/cli/selfenergy/__init__.py 60.00% 2 Missing ⚠️
src/phelel/velph/cli/transport/__init__.py 50.00% 1 Missing ⚠️
src/phelel/velph/cli/transport/generate.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #29      +/-   ##
===========================================
- Coverage    73.42%   73.27%   -0.16%     
===========================================
  Files           74       75       +1     
  Lines         5223     5320      +97     
===========================================
+ Hits          3835     3898      +63     
- Misses        1388     1422      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atztogo atztogo merged commit d12a227 into develop Sep 25, 2024
2 checks passed
@atztogo atztogo deleted the fix-issue-28 branch September 25, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants