-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cordova-plugin-file dependency to 6.0.1 #18
base: master
Are you sure you want to change the base?
Update cordova-plugin-file dependency to 6.0.1 #18
Conversation
@kerrishotts could you review this pull request? I think these changes did not cause the CI fail, and it works fine with both |
@kerrishotts This would be awesome! Please take a look. |
@henry61024 Any issues over the last few months? Have you implemented it in your app? |
@benmcmaster Yes I have implemented in our app, and has no related issue since I update |
any update of this? thanks guys! |
@henry61024 @benmcmaster Guys, what do you think to create other npm package for this? It seems that this repo is no longer maintained |
@jdnichollsc You can use this forked repository instead Change the <plugin name="cordova-plugin-photokandy-video-thumbnail" spec="https://github.com/GSS-CRD/PKVideoThumbnail.git" /> |
I have issues using Cordova >= 8.1.2 pointing to Github repositories, cordova can't find these plugins |
We're working fine on Cordova |
Yeah, that repo only works with cordova < 8 |
Platform affected
What does this PR do?
Change cordova-plugin-file dependency to
6.0.1
.This PR solves #17.
What testing has been done on this change?
Has been added to project and tested on :