Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cordova-plugin-file dependency to 6.0.1 #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

henry61024
Copy link

@henry61024 henry61024 commented May 17, 2018

Platform affected

  • iOS
  • Android

What does this PR do?

Change cordova-plugin-file dependency to 6.0.1.

This PR solves #17.

What testing has been done on this change?

Has been added to project and tested on :

  • iOS Simulator 11.3
  • Android Simulator 8.1

@henry61024
Copy link
Author

@kerrishotts could you review this pull request?

I think these changes did not cause the CI fail, and it works fine with both iOS Simulator 11.3 & Android Simulator 8.1.

@benmcmaster
Copy link

@kerrishotts This would be awesome! Please take a look.

@benmcmaster
Copy link

@henry61024 Any issues over the last few months? Have you implemented it in your app?

@henry61024
Copy link
Author

henry61024 commented Dec 12, 2018

@benmcmaster Yes I have implemented in our app, and has no related issue since I update cordova-plugin-file dependency to 6.0.1

@jdnichollsc
Copy link

any update of this? thanks guys!

@jdnichollsc
Copy link

@henry61024 @benmcmaster Guys, what do you think to create other npm package for this? It seems that this repo is no longer maintained

@henry61024
Copy link
Author

henry61024 commented Apr 17, 2019

@jdnichollsc You can use this forked repository instead

Change the spec of cordova-plugin-photokandy-video-thumbnail inside config.xml to the following config does the trick:

<plugin name="cordova-plugin-photokandy-video-thumbnail" spec="https://github.com/GSS-CRD/PKVideoThumbnail.git" />

@jdnichollsc
Copy link

I have issues using Cordova >= 8.1.2 pointing to Github repositories, cordova can't find these plugins

@henry61024
Copy link
Author

We're working fine on Cordova 7.1.0

@jdnichollsc
Copy link

Yeah, that repo only works with cordova < 8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants