Handle extensions state #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! Thank you @jimwins! Note though that checking out to I tried the script without the doc-en changes, and it works fine. |
|
@Girgias, since you've worked on that script, you may want to have a look. |
jimwins
force-pushed
the
handle-extensions-state
branch
from
9c36b11 to
50d2b26
Compare
|
Okay, rebased without the |
Girgias
approved these changes
Aug 7, 2024
|
I'm confused why the CI is complaining about the extensions.xml file not being up to date |
|
I think the script would need to be run without the |
|
Because now that the script handles State, doc-en is out of date. Thus php/doc-en#3645. |
|
And doc-en is green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to php/doc-en#3643.