Fix CHM downloads due to certificate weirdness (fixes php/systems#58) #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimwins
force-pushed
the
fix-chm-download
branch
from
c58dca9 to
0dad815
Compare
|
Whoops, branched from another branch instead of master. Fixed. |
|
Hmm, I'm slightly uneasy to deactivate the certificate check, and after all, the latests CHMs are only from Aug 17th. Maybe we should wait a bit. Hopefully @mumumu is well. |
|
Sorry for too late reply. I have opened port 80 of my host, so this PR can be closed if you change the following URL to https://github.com/php/doc-base/blob/master/scripts/fetch-chms.php#L3 |
jimwins
force-pushed
the
fix-chm-download
branch
from
0dad815 to
087903c
Compare
|
Well, looks like it's still not working with this change. Someone with access to rsync.php.net, like @derickr, will need to debug. |
|
And now they are flowing again, so either I just wasn't patient enough or someone loosened the gears. Latest CHM downloads re from 18 Oct 2024. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.