Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ini_get: Update example to use ini_parse_quantity() #4372

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

edorian
Copy link
Contributor

@edorian edorian commented Jan 8, 2025

  • Use ini_parse_quantity instead of custom code for ini value parsing.
  • Replace register_globals ini value with something more current, as register_globals was removed in, I think, PHP 5.4.
  • Change the wording for the ini_parse_quantity example to not contain “similar to” as it's deterministic output.

Resolves #4185

@TimWolla TimWolla requested a review from Girgias January 8, 2025 14:25
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created this PR together with edorian to showcase how editing the docs works. Requesting another review for wording approval.

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Girgias Girgias merged commit 4c016ab into php:master Jan 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ini_get() to make use of ini_parse_quantity()
3 participants