Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support enum links #188

Merged
merged 5 commits into from
Feb 6, 2025
Merged

Conversation

SakiTakamachi
Copy link
Member

@SakiTakamachi SakiTakamachi commented Jan 29, 2025

In my local:

スクリーンショット 2025-01-31 17 27 57

Actually, it would be nice to be able to link RoundingMode::HalfAwayFromZero as well, but that might be a good idea to wait for a follow-up.

@SakiTakamachi
Copy link
Member Author

@haszi
With this change enumname behaves like classname, are there any concerns?
(I'm not very familiar with the docs)

@TimWolla TimWolla requested review from Girgias and haszi January 30, 2025 18:33
@TimWolla TimWolla mentioned this pull request Jan 28, 2025
5 tasks
@SakiTakamachi SakiTakamachi force-pushed the add_support_enum_links branch 2 times, most recently from 7f5e3a9 to d5d5e3f Compare January 31, 2025 08:20
@SakiTakamachi SakiTakamachi force-pushed the add_support_enum_links branch from d5d5e3f to a3d7cd0 Compare January 31, 2025 08:24
@SakiTakamachi SakiTakamachi marked this pull request as ready for review January 31, 2025 08:29
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Girgias Girgias merged commit 3c00a1a into php:master Feb 6, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants