Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory allocations in querySelector resolution #17821

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

nielsdos
Copy link
Member

These memory allocations at the entry don't need to happen because they're live for the entire evaluation.

These memory allocations at the entry don't need to happen because
they're live for the entire evaluation.
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lctm your change probably right hopefully not introducing subtle bug but do not think so.

@nielsdos nielsdos merged commit 8f5a6ff into php:master Feb 16, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants