Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove POP3 from error message when unable to connect to bounce mailbox #1066

Merged
merged 2 commits into from
Jan 26, 2025
Merged

Remove POP3 from error message when unable to connect to bounce mailbox #1066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08bf354
update PR template
michield Jan 15, 2025
008db69
Remove POP3 from error message
bramley Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,23 @@
<!---Thanks for contributing to phpList!-->
<!--- Thanks for contributing to phpList!-->

## Description
<!--- Please provide a general description of your changes in the Pull Request -->

## Contributor License Agreement

<!--

before we can accept your PR, if you haven't done this yet, please sign the

Contributor License Agreement at https://www.phplist.com/cla

Many thanks

the phpList Team

-->


## Related Issue


Expand Down
2 changes: 1 addition & 1 deletion public_html/lists/admin/processbounces.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ function processPop($server, $user, $password)
$link = imap_open($mailbox, $user, $password);

if (!$link) {
outputProcessBounce($GLOBALS['I18N']->get('Cannot create POP3 connection to')." $mailbox: ".imap_last_error());
outputProcessBounce($GLOBALS['I18N']->get('Cannot create connection to')." $mailbox: ".imap_last_error());

return false;
}
Expand Down
Loading