Enabling constructor check for class-string variables #3661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayuprc
force-pushed
the
resolve-12010
branch
2 times, most recently
from
7663d06 to
f6c5c24
Compare
sayuprc
force-pushed
the
resolve-12010
branch
from
f6c5c24 to
18529dc
Compare
|
This pull request has been marked as ready for review. |
sayuprc
force-pushed
the
resolve-12010
branch
from
18529dc to
615d5e6
Compare
staabm
reviewed
Dec 1, 2024
| @@ -245,6 +248,18 @@ private function getClassNames(Node $node, Scope $scope): array | |||
|
|
|||
| $type = $scope->getType($node->class); | |||
|
|
|||
| if (str_starts_with($type->describe(VerbosityLevel::precise()), 'class-string')) { | |||
There was a problem hiding this comment.
could this use Type->isClassStringType()?
staabm
reviewed
Dec 1, 2024
Comment on lines
252
to
260
| $classStringObjectType = $type->getClassStringObjectType(); | ||
|
|
||
| return array_map( | ||
| static fn (string $name): array => [$name, true], | ||
| array_filter($classStringObjectType->getObjectClassNames(), function (string $name): bool { | ||
| $reflectionClass = $this->reflectionProvider->getClass($name); | ||
| return !$reflectionClass->isAbstract() && !$reflectionClass->isInterface(); | ||
| }), | ||
| ); |
There was a problem hiding this comment.
could this be shortened with Type->getObjectClassReflections()?
staabm
approved these changes
Dec 9, 2024
ondrejmirtes
requested changes
Jan 16, 2025
| @@ -245,6 +248,18 @@ private function getClassNames(Node $node, Scope $scope): array | |||
|
|
|||
| $type = $scope->getType($node->class); | |||
|
|
|||
| if (str_starts_with($type->describe(VerbosityLevel::precise()), 'class-string')) { | |||
There was a problem hiding this comment.
I'm sorry, rule logic can't rely on string type descriptions.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed to check constructor arguments when creating an instance from a variable containing a class-string.
Skip checking if T in class-string is abstract or interface.
resolve phpstan/phpstan#12010