Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace authentication exceptions with session storage #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aroberts91
Copy link

This PR attempts to replace the Login/Logout exceptions thrown when the wp_login/wp_logout actions are called with session based logic.

As explained in the linked issue, these exceptions can cause other plugins which rely on wp_login to fail or behave unexpectedly when the exceptions are thrown.

Instead of throwing the exceptions I've attempted storing the required data in session and looking for it within createWordpressResponse.

Resolves #42

@williarin
Copy link
Member

Thank you for your contribution! I need to try it with a project that uses Symfony auth as well, I'll let you know if it works.

@aroberts91
Copy link
Author

Hi @williarin, were you able to test this?

@williarin
Copy link
Member

Really sorry I haven't had the time yet! I will do my best to try it in the following days. On your side have you found any problem to keep Symfony session in sync with this solution or does it work as expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GravityForms login issue
2 participants