Add .pre-commit-config.yaml

[maestroque]

Add a pre-commit configuration file, as in phys2bids

Proposed Changes

• All the python style checkers are added
• rst checkers are added as is from phys2bids

Change Type

• bugfix (+0.0.1)
• minor (+0.1.0)
• major (+1.0.0)
• refactoring (no version update)
• test (no version update)
• infrastructure (no version update)
• documentation (no version update)
• other

Checklist before review

• I added everything I wanted to add to this PR.
• [Code or tests only] I wrote/updated the necessary docstrings.
• [Code or tests only] I ran and passed tests locally.
• [Documentation only] I built the docs locally.
• My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
• My code respects the adopted style, especially linting conventions.
• The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
• I added or indicated the right labels.

• I added information regarding the timeline of completion for this PR.

• Please, comment on my PR while it's a draft and give me feedback on the development!

[smoia]

I see some formatting has happened ;)

The main feedback is to change the setup.cfg configuration - you can take a look at phys2bids' or nigsp's one to see how to set pre-commit and its hooks up!

[smoia]

This may benefit from having a look at #41 (?)

[maestroque]

@smoia @me-pic @m-miedema I believe this is ready, feel free to have a look

[maestroque]

@me-pic @m-miedema @smoia This should be ready to merge. I opened physiopy/prep4phys#2 for the failing neurokit tests, since they are outdated and I suppose they will be addressed in another PR (or will be re-written completely). For the time being I just added a # noqa

[smoia]

Looks like the changes worked, good job!

Did you run tests locally? If not, could you do that, please? If they break on something like the old workflows, that's fine, but otherwise it's good to check that the blacking of the scripts didn't break anything (shouldn't, but just to be sure!)

[smoia]

Might be worth adding black config as well?

[maestroque]

There is no support for setup.cfg (issue), we would have to add a pyproject.toml instead.
I don't see any desired configuration option other than perhaps the --exclude option.

However, I don't see any real benefit in excluding files like versioneer.py and not having style uniformity. Let me know your thoughts.

[maestroque]

@smoia I ran them locally yes, they have the same behavior as in master branch currently.

[smoia]

Sorry, you are right about black in setup.cfg.

I got confused with extended Flake8 settings to match Black:

ignore = E126, E402, W503, F401, F811
max-line-length = 88
extend-ignore = E203, E501
extend-select = B950

[maestroque]

Done

[smoia]

@smoia I ran them locally yes, they have the same behavior as in master branch currently.

This is awesome though!

[maestroque]

@smoia @m-miedema @me-pic this should be ready to go now

[smoia]

Awesome!