Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding sound for soldier, player and weapons #49

Merged
merged 15 commits into from
Jan 17, 2024
Merged

Adding sound for soldier, player and weapons #49

merged 15 commits into from
Jan 17, 2024

Conversation

Milosz-cat
Copy link
Collaborator

@Milosz-cat Milosz-cat commented Jan 16, 2024 •
edited by pietrykovsky
Loading

Features:

  • added audio assets
  • updated AssetLoader with audio assets
  • added weapon sounds
  • added soundtrack
  • added enemies sounds

To do:

  • handling for players death sound
  • handling for players victory sound
  • refactor

closes #39

@Milosz-cat Milosz-cat linked an issue Jan 16, 2024 that may be closed by this pull request
Add sound mechanism #39
Closed
@Milosz-cat Milosz-cat self-assigned this Jan 17, 2024
@pietrykovsky pietrykovsky added the enhancement New feature or request label Jan 17, 2024
@pietrykovsky pietrykovsky self-assigned this Jan 17, 2024
@pietrykovsky pietrykovsky marked this pull request as draft January 17, 2024 01:20
@pietrykovsky pietrykovsky marked this pull request as ready for review January 17, 2024 10:34
@pietrykovsky pietrykovsky merged commit 34c4675 into master Jan 17, 2024
4 checks passed
@pietrykovsky pietrykovsky deleted the 39-add-sound-mechanism branch January 17, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Milosz-cat Milosz-cat

@pietrykovsky pietrykovsky

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add sound mechanism
2 participants
@Milosz-cat @pietrykovsky