Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Followup #767 Grid permissions #786

Merged
merged 6 commits into from
Dec 10, 2024
Merged

[Task]: Followup #767 Grid permissions #786

merged 6 commits into from
Dec 10, 2024

Conversation

kingjia90
Copy link
Contributor

@kingjia90 kingjia90 commented Dec 9, 2024 •
edited
Loading

Without the CONCAT caused problems on permission of a specific element

@kingjia90 kingjia90 added this to the 1.7.2 milestone Dec 9, 2024
@kingjia90 kingjia90 changed the title [Task[: Followup #767 Grid permissions [Task]: Followup #767 Grid permissions Dec 9, 2024
@kingjia90
Copy link
Contributor Author

Given the table structure with clear distinction between path and key, the CONCAT could be avoided by a double condition
first to check the element itself, then the ones that have the same path as the fullpath for its children
image

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 10, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
3 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kingjia90 kingjia90 merged commit ef1c3cc into 1.7 Dec 10, 2024
10 checks passed
@kingjia90 kingjia90 deleted the followup-grid branch December 10, 2024 09:36
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Pimcore:Priority
Projects
None yet
Milestone
1.7.2
Development

Successfully merging this pull request may close these issues.
1 participant
@kingjia90