[BUG] fix permission check in GridHelperService for wrong query column if type is asset #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Thank you for your PR! |
|
@la-lisa this PR has a lot unrelated commits in it. |
la-lisa
force-pushed
the
bugfix/grid-helper-assets
branch
from
2dbffe9 to
d9e8ede
Compare
|
@fashxp done. Sorry did not check the history. |
|
@la-lisa It would be nice to have this in 1.6. Could you please re-base the branch to 1.6? Thanks a lot |
…n if type is asset
la-lisa
force-pushed
the
bugfix/grid-helper-assets
branch
from
d9e8ede to
2dd4d19
Compare
fashxp
requested changes
Dec 17, 2024
fashxp
approved these changes
Dec 17, 2024
# Conflicts: # src/Helper/GridHelperService.php
|
|
@la-lisa Thanks for the fix and your fast responses |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grid-proxy action fails if non admin user wants to access assets list in folder. Assets table has no column key only filename.