Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes & improvements #35

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Various fixes & improvements #35

merged 3 commits into from
Jan 14, 2025

Conversation

Gadgetoid
Copy link
Member

Round up of a few overdue fixes and quality of life improvements.

I've added some comments to the examples that should save future Pirate Audio users a little hassle. Thanks to Floyd for finally poking me to connect the dots. Watch his Fluid Synth build video here: https://www.youtube.com/watch?v=ilmhX1j-ENU

Fix regression raised in #33.
@Gadgetoid
Copy link
Member Author

For users wanting to use multiple ST7789 boards, and who have found it's all suddenly rather broken, this is a "The Linux Kernel No Longer Lets You Share Pins" problem.

Fortunately we don't strictly need to share pins.

Using this branch it should be possible to pass in a pin object, in lieu of an int, and the ST7789 library will use that. I still need to whip up an example, but I stuck some ✨ Factory Functions ✨ onto ST7789 so you can share the same data/command pin like so:

dc = st7789.ST7789.get_dc_pin(pin)

display1 = st7789.ST7789(... dc=dc ...)
display2 = st7789.ST7789(... dc=dc ...)

I hasten to add that I need to dig up my breakouts and Breakout Garden and actually test these changes.

Allow the same pin instance to be passed into multiple driver instances.

Fixes #34.
@Gadgetoid Gadgetoid force-pushed the feature/floyd-made-me-do-it branch from d00b9a9 to aba5f1f Compare November 11, 2024 13:45
@Gadgetoid Gadgetoid force-pushed the feature/floyd-made-me-do-it branch from c0dcb1f to 9aabd78 Compare January 14, 2025 15:29
@Gadgetoid Gadgetoid merged commit 2e0df28 into main Jan 14, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant