Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve instructions for local builds #19

Closed
wants to merge 1 commit into from
Closed

Improve instructions for local builds #19

wants to merge 1 commit into from

Conversation

WhyNotHugo
Copy link
Member

No description provided.

@WhyNotHugo
Copy link
Member Author

I've tried lektor server but it's not working for me. I think some dependencies have incompatible versions:

> lektor server       
Traceback (most recent call last):
  File "/home/hugo/.local/state/virtualenvs/pimutils-meta/bin/lektor", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/hugo/.local/state/virtualenvs/pimutils-meta/lib/python3.11/site-packages/lektor/cli.py", line 621, in main
    cli.main(args=args, prog_name=name)
  File "/home/hugo/.local/state/virtualenvs/pimutils-meta/lib/python3.11/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/home/hugo/.local/state/virtualenvs/pimutils-meta/lib/python3.11/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/hugo/.local/state/virtualenvs/pimutils-meta/lib/python3.11/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/hugo/.local/state/virtualenvs/pimutils-meta/lib/python3.11/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/hugo/.local/state/virtualenvs/pimutils-meta/lib/python3.11/site-packages/click/decorators.py", line 92, in new_func
    return ctx.invoke(f, obj, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/hugo/.local/state/virtualenvs/pimutils-meta/lib/python3.11/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/hugo/.local/state/virtualenvs/pimutils-meta/lib/python3.11/site-packages/lektor/cli.py", line 336, in server_cmd
    from lektor.devserver import run_server
  File "/home/hugo/.local/state/virtualenvs/pimutils-meta/lib/python3.11/site-packages/lektor/devserver.py", line 9, in <module>
    from lektor.admin import WebAdmin
  File "/home/hugo/.local/state/virtualenvs/pimutils-meta/lib/python3.11/site-packages/lektor/admin/__init__.py", line 1, in <module>
    from .webui import WebAdmin
  File "/home/hugo/.local/state/virtualenvs/pimutils-meta/lib/python3.11/site-packages/lektor/admin/webui.py", line 6, in <module>
    from flask import abort
  File "/home/hugo/.local/state/virtualenvs/pimutils-meta/lib/python3.11/site-packages/flask/__init__.py", line 14, in <module>
    from jinja2 import escape
ImportError: cannot import name 'escape' from 'jinja2' (/home/hugo/.local/state/virtualenvs/pimutils-meta/lib/python3.11/site-packages/jinja2/__init__.py)

@untitaker
Copy link
Member

we should get rid of it entirely. lektor does not care about working with recent python dependencies, and i had major issues trying to pin flask/jinja/werkzeug to the right old versions.

@WhyNotHugo
Copy link
Member Author

Remove it was my first though, but I though I'd try and give it a chance first.

I'll drop this PR and simply replace it entirely.

@WhyNotHugo WhyNotHugo closed this Oct 11, 2023
@untitaker
Copy link
Member

untitaker commented Oct 11, 2023 via email

@WhyNotHugo WhyNotHugo deleted the usage branch October 11, 2023 13:28
WhyNotHugo added a commit that referenced this pull request May 16, 2024
Lektor doesn't work with recent Python dependencies. This should be
easier to work with.

See: #19
WhyNotHugo added a commit that referenced this pull request May 16, 2024
Lektor doesn't work with recent Python dependencies. This should be
easier to work with.

See: #19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants