Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove kubernetes main mod #5419

Merged
merged 18 commits into from
Dec 7, 2023
Merged

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Nov 27, 2023

What problem does this PR solve?

When bumping K8s deps to v1.24, kubernetes/kubernetes#119504.

So we remove k8s.io/kubernetes in this PR before bump K8s deps to v1.24.

  • copy some code both for the apps and E2E test
  • remove / comment-out some unnecessary code

also ref pingcap/advanced-statefulset#97

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot ti-chi-bot bot requested a review from shonge November 27, 2023 07:55
@csuzhangxc csuzhangxc changed the title [WIP] remove some kubernetes main mod in app [WIP] remove kubernetes main mod Nov 27, 2023
@ti-chi-bot ti-chi-bot bot added the size/L label Nov 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2023

Codecov Report

Merging #5419 (db708b9) into master (6c87ec1) will increase coverage by 2.87%.
The diff coverage is 81.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5419      +/-   ##
==========================================
+ Coverage   61.41%   64.29%   +2.87%     
==========================================
  Files         228      241      +13     
  Lines       29102    32920    +3818     
==========================================
+ Hits        17874    21166    +3292     
- Misses       9471     9925     +454     
- Partials     1757     1829      +72     
Flag Coverage Δ
e2e 34.52% <66.17%> (?)
unittest 61.42% <74.60%> (+0.01%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/XXL and removed size/L labels Nov 30, 2023
@csuzhangxc csuzhangxc changed the title [WIP] remove kubernetes main mod remove kubernetes main mod Dec 4, 2023
@csuzhangxc
Copy link
Member Author

/run-all-tests

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-br

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-serial

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-serial

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 7, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KanShiori

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 7, 2023
@ti-chi-bot ti-chi-bot bot removed the lgtm label Dec 7, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-07 02:23:54.438765675 +0000 UTC m=+1667063.103991871: ☑️ agreed by KanShiori.
  • 2023-12-07 02:24:05.821976102 +0000 UTC m=+1667074.487202296: ✖️🔁 reset by csuzhangxc.

Copy link
Contributor

ti-chi-bot bot commented Dec 7, 2023

New changes are detected. LGTM label has been removed.

@csuzhangxc csuzhangxc merged commit e222b4f into pingcap:master Dec 7, 2023
@csuzhangxc csuzhangxc deleted the remove-kube branch December 7, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants