-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug fix] Take into account PD peer port and PD client port when pdAddresses from TidbCluster manifest used over Discovery service in pd, tidb and tikv startup scripts #5438
Conversation
… one published to DNS
This reverts commit 6a9990a.
…orDnsNameIpMatchOnStartup
…orDnsNameIpMatchOnStartup
…only with v2 scripts
…r into 1.5.1-airbnb-dev
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5438 +/- ##
=======================================
Coverage 61.41% 61.41%
=======================================
Files 228 228
Lines 29102 29114 +12
=======================================
+ Hits 17872 17881 +9
- Misses 9472 9473 +1
- Partials 1758 1760 +2
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csuzhangxc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
it's better to add manual test steps in the PR description. |
/cherry-pick release-1.5 |
@csuzhangxc: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
…dresses from TidbCluster manifest used over Discovery service in pd, tidb and tikv startup scripts (pingcap#5438)
…dresses from TidbCluster manifest used over Discovery service in pd, tidb and tikv startup scripts (#5438) (#5444) Co-authored-by: Sergey <[email protected]>
What problem does this PR solve?
Currently non default security scheme nor PD peer port nor PD client port are taken into account by startup scripts if pdAddresses from TidbCluster manifest used over Discovery service
What is changed and how does it work?
Adds support of non default scheme, PD peer port and PD client to startup scripts v2
Code changes
Tests
Side effects
Related changes
Release Notes
NONE