Add trap to create a path when BR container exit (#5431) #5443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-1.5 #5443 +/- ##
===============================================
+ Coverage 61.50% 67.96% +6.46%
===============================================
Files 228 241 +13
Lines 29092 33037 +3945
===============================================
+ Hits 17893 22455 +4562
+ Misses 9446 8795 -651
- Partials 1753 1787 +34
|
|
/run-pull-e2e-kind-across-kubernetes |
BornChanger
approved these changes
Dec 5, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/run-pull-e2e-kind |
1 similar comment
|
/run-pull-e2e-kind |
|
/run-pull-e2e-kind-across-kubernetes |
[LGTM Timeline notifier]Timeline:
|
|
New changes are detected. LGTM label has been removed. |
|
/retest |
|
/run-pull-e2e-kind-serial |
|
/run-pull-e2e-kind-basic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #5431
What problem does this PR solve?
Closes #5430
What is changed and how does it work?
Create a path when the main container exits, the sidecar can check the path once it shows up it can exit.
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.