Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: collect duration of failed stats cache sync #58795

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

statistics: collect duration of failed stats cache sync #58795

wants to merge 2 commits into from
+4 −3

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jan 8, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #58797

Problem Summary:

What changed and how does it work?

if it failed, tidb cannot collect the timeout for it.

Image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

collect duration of failed stats cache sync

收集失败的统计信息同步的耗时

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hawkingrei, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/planner SIG: Planner labels Jan 8, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.7837%. Comparing base (d1ed962) to head (a485971).
Report is 6 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #58795        +/-   ##
================================================
+ Coverage   73.0889%   73.7837%   +0.6947%     
================================================
  Files          1676       1706        +30     
  Lines        463746     472313      +8567     
================================================
+ Hits         338947     348490      +9543     
+ Misses       103954     102226      -1728     
- Partials      20845      21597       +752
Flag Coverage Δ
integration 45.6733% <100.0000%> (?)
unit 72.3251% <100.0000%> (+0.0356%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.7389% <ø> (+0.0328%) ⬆️

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. labels Jan 8, 2025
@hawkingrei
update 0108
a485971 
Signed-off-by: Weizhen Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros Awaiting requested review from winoros

@qw4990 qw4990 Awaiting requested review from qw4990

@AilinKid AilinKid Awaiting requested review from AilinKid

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forget to collect duration of failed stats cache sync
1 participant
@hawkingrei