Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: collect duration of failed stats cache sync #58795

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jan 8, 2025

What problem does this PR solve?

Issue Number: close #58797

Problem Summary:

What changed and how does it work?

if it failed, tidb cannot collect the timeout for it.

Image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

collect duration of failed stats cache sync

收集失败的统计信息同步的耗时

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/planner SIG: Planner labels Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.4082%. Comparing base (d1ed962) to head (a485971).
Report is 34 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58795        +/-   ##
================================================
+ Coverage   73.0889%   74.4082%   +1.3193%     
================================================
  Files          1676       1708        +32     
  Lines        463746     477639     +13893     
================================================
+ Hits         338947     355403     +16456     
+ Misses       103954     100863      -3091     
- Partials      20845      21373       +528     
Flag Coverage Δ
integration 46.5864% <100.0000%> (?)
unit 73.0040% <100.0000%> (+0.7144%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.7689% <ø> (+0.0628%) ⬆️

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. labels Jan 8, 2025
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 13, 2025
Copy link

ti-chi-bot bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 13, 2025
Copy link

ti-chi-bot bot commented Jan 13, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-13 07:22:30.697987168 +0000 UTC m=+770293.986818873: ☑️ agreed by AilinKid.
  • 2025-01-13 07:26:03.558553271 +0000 UTC m=+770506.847384977: ☑️ agreed by qw4990.

@ti-chi-bot ti-chi-bot bot merged commit d0cccca into pingcap:master Jan 13, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forget to collect duration of failed stats cache sync
3 participants