Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttl: disable paging in TTL #58759

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

lcwangchao
Copy link
Collaborator

@lcwangchao lcwangchao commented Jan 7, 2025

What problem does this PR solve?

Issue Number: close #58342

What changed and how does it work?

disable paging in TTL

image

See the metrics above. Left is @@tidb_enable_paging=1 and right is @@tidb_enable_paging=0. The cop operations decreases a little (~7%)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 7, 2025
Copy link

tiprow bot commented Jan 7, 2025

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.7805%. Comparing base (c199ddf) to head (bb4651c).
Report is 14 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58759        +/-   ##
================================================
+ Coverage   73.0885%   74.7805%   +1.6919%     
================================================
  Files          1676       1677         +1     
  Lines        463643     476651     +13008     
================================================
+ Hits         338870     356442     +17572     
+ Misses       103924      99110      -4814     
- Partials      20849      21099       +250     
Flag Coverage Δ
integration 44.3659% <0.0000%> (?)
unit 73.6134% <95.4545%> (+1.3270%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.7599% <ø> (+0.0269%) ⬆️

@YangKeao YangKeao self-requested a review January 8, 2025 09:11
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 9, 2025
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 9, 2025
Copy link

ti-chi-bot bot commented Jan 9, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-09 02:29:04.033283728 +0000 UTC m=+407087.322115433: ☑️ agreed by YangKeao.
  • 2025-01-09 02:52:47.255871684 +0000 UTC m=+408510.544703389: ☑️ agreed by bb7133.

@ti-chi-bot ti-chi-bot bot merged commit fedc98a into pingcap:master Jan 9, 2025
24 checks passed
@lcwangchao lcwangchao deleted the ttl_disable_paging branch January 9, 2025 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tune tidb_enable_paging or tidb_min_paging_size to make TTL scan more efficient
3 participants