-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infoschema,metrics: add a metric for infoschema v2 cache objects count #58781
base: master
Are you sure you want to change the base?
Conversation
Hi @tiancaiamao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #58781 +/- ##
================================================
+ Coverage 73.0858% 74.3894% +1.3036%
================================================
Files 1676 1721 +45
Lines 463685 471775 +8090
================================================
+ Hits 338888 350951 +12063
+ Misses 103941 98510 -5431
- Partials 20856 22314 +1458
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@tiancaiamao: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #50959
Problem Summary:
What changed and how does it work?
Add a metrics for infoschema v2 schema cache objects count.
So that the user can calculate or estimate the size of each table.
Check List
Tests
Use the new tidb.json
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.