-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mysql, errno: Unify the mysql error codes and related error messages. #58790
base: master
Are you sure you want to change the base?
Conversation
Hi @wddevries. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…d use error codes and messages in pkg/errno.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #58790 +/- ##
================================================
+ Coverage 73.4645% 74.7454% +1.2808%
================================================
Files 1676 1722 +46
Lines 464424 472516 +8092
================================================
+ Hits 341187 353184 +11997
+ Misses 102397 97068 -5329
- Partials 20840 22264 +1424
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@wddevries: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #29026
Problem Summary:
There are two copies of most error codes and error messages. This pull request:
The error messages in both the mysql package and errno were compared to insure compatibility.
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.