-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: optimize stats delta dumping with batch processing #58791
statistics: optimize stats delta dumping with batch processing #58791
Conversation
Signed-off-by: Rustin170506 <[email protected]>
Signed-off-by: Rustin170506 <[email protected]>
Signed-off-by: Rustin170506 <[email protected]>
Signed-off-by: Rustin170506 <[email protected]>
Signed-off-by: Rustin170506 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #58791 +/- ##
================================================
+ Coverage 73.0741% 73.9479% +0.8738%
================================================
Files 1676 1708 +32
Lines 463762 477248 +13486
================================================
+ Hits 338890 352915 +14025
+ Misses 104006 102683 -1323
- Partials 20866 21650 +784
Flags with carried forward coverage won't be shown. Click here to find out more.
|
… check for batchUpdates Signed-off-by: Rustin170506 <[email protected]>
/retest |
1 similar comment
/retest |
…r slow operations Signed-off-by: Rustin170506 <[email protected]>
…ng operations Signed-off-by: Rustin170506 <[email protected]>
… and improve performance logging Signed-off-by: Rustin170506 <[email protected]>
/retest |
…erformance Signed-off-by: Rustin170506 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔢 Self-check (PR reviewed by myself and ready for feedback.)
/hold |
…g of table IDs and enhance assertions for batch updates Signed-off-by: Rustin170506 <[email protected]>
590f4e5
to
dc8ce37
Compare
/retest |
dc8ce37
to
6a5bd41
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6a5bd41
to
24f6f64
Compare
… table handling and preventing write conflicts Signed-off-by: Rustin170506 <[email protected]>
24f6f64
to
4d40e1b
Compare
/unhold |
@Rustin170506: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #57869
close #58331
Problem Summary:
What changed and how does it work?
In this PR I changed
DumpStatsDeltaToKV
to dump the stats in batch instead of one by one. This will significantly improve the performance of the dump process. From my tests, the duration dropped from 40 minutes to 20 seconds under 100m table workload.See more: #57869 (comment)
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.