Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: optimize stats delta dumping with batch processing #58996

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Jan 16, 2025

What problem does this PR solve?

Issue Number: ref #57869

ref #58890
ref #58884
ref #58885
ref #58993
ref #59022

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 16, 2025
@Rustin170506 Rustin170506 force-pushed the rustin-patch-dump-stats-quick-for-hotfix branch from 5964a2c to ffe10c7 Compare January 16, 2025 12:35
Benjamin2037
Benjamin2037 previously approved these changes Jan 16, 2025
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 16, 2025
winoros
winoros previously approved these changes Jan 16, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 16, 2025
Copy link

ti-chi-bot bot commented Jan 16, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-16 12:46:04.974874024 +0000 UTC m=+209036.429920173: ☑️ agreed by Benjamin2037.
  • 2025-01-16 12:48:08.107243076 +0000 UTC m=+209159.562289224: ☑️ agreed by winoros.

GMHDBJD
GMHDBJD previously approved these changes Jan 16, 2025
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 76.82927% with 57 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5-20250114-v8.5.0@722347b). Learn more about missing BASE report.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-8.5-20250114-v8.5.0     #58996   +/-   ##
================================================================
  Coverage                               ?   57.1991%           
================================================================
  Files                                  ?       1779           
  Lines                                  ?     630866           
  Branches                               ?          0           
================================================================
  Hits                                   ?     360850           
  Misses                                 ?     245068           
  Partials                               ?      24948           
Flag Coverage Δ
integration 37.3379% <67.0731%> (?)
unit 72.4062% <74.7967%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8711% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 55.2477% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added the approved label Jan 16, 2025
@Benjamin2037
Copy link
Collaborator

/retest

2 similar comments
@Rustin170506
Copy link
Member Author

/retest

@Rustin170506
Copy link
Member Author

/retest

@yinsustart
Copy link

/test check-dev2

Copy link

tiprow bot commented Jan 17, 2025

@yinsustart: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Rustin170506 Rustin170506 dismissed stale reviews from GMHDBJD, winoros, and Benjamin2037 via c6e45d8 January 17, 2025 09:04
@ti-chi-bot ti-chi-bot bot removed the approved label Jan 17, 2025
@Rustin170506
Copy link
Member Author

/retest

@Rustin170506 Rustin170506 force-pushed the rustin-patch-dump-stats-quick-for-hotfix branch 2 times, most recently from 881b71c to 2318423 Compare January 17, 2025 10:59
@Rustin170506 Rustin170506 force-pushed the rustin-patch-dump-stats-quick-for-hotfix branch from 2318423 to 66e0bb5 Compare January 17, 2025 11:27
@ti-chi-bot ti-chi-bot bot added the approved label Jan 17, 2025
@Rustin170506
Copy link
Member Author

/approve

Copy link

ti-chi-bot bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, Rustin170506, winoros, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit f069f0b into pingcap:release-8.5-20250114-v8.5.0 Jan 17, 2025
18 checks passed
@Rustin170506 Rustin170506 deleted the rustin-patch-dump-stats-quick-for-hotfix branch January 17, 2025 12:08
@Rustin170506 Rustin170506 restored the rustin-patch-dump-stats-quick-for-hotfix branch January 17, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants