*: make chunk.SwapColumn
private (#57274)
#59190
Open
+5,762
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #57274
What problem does this PR solve?
Issue Number: close #55885
Problem Summary:
The root cause is in Limit executor, it has an inline projection, but it use
chunk.SwapColumn
directly to do the projection, which will cause error if theLimit
's output contains multiple column that point to same shallow column in input ChunkWhat changed and how does it work?
This pr
chunk.SwapColumn
a private method, so it will not be used mistakenlyColumnEvaluator
toColumnSwapHelper
and move it fromexpression
package tochunk
packageColumnSwapHelper
to do the inline projection inLimit
executor.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.