Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize universal tests #1492

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Modernize universal tests #1492

merged 1 commit into from
Apr 16, 2024

Conversation

tylerwowen
Copy link
Contributor

@tylerwowen tylerwowen commented Mar 4, 2024 •
edited
Loading

Remove public
Use org.junit.jupiter.api.Assertions

@tylerwowen tylerwowen requested a review from a team as a code owner March 4, 2024 22:09
@github-actions github-actions bot added the deploy-service Includes changes to deploy-service label Mar 4, 2024
@tylerwowen tylerwowen force-pushed the spr/master/a1e3bceb branch from 43db610 to 2979626 Compare March 4, 2024 22:20
@tylerwowen tylerwowen force-pushed the spr/master/aa055770 branch 2 times, most recently from dc7f06f to 3d21581 Compare March 5, 2024 03:18
@tylerwowen tylerwowen force-pushed the spr/master/a1e3bceb branch 2 times, most recently from 347850b to a603d52 Compare March 5, 2024 03:23
@tylerwowen tylerwowen force-pushed the spr/master/aa055770 branch 2 times, most recently from d8332f5 to b2b1516 Compare March 6, 2024 01:37
@tylerwowen tylerwowen force-pushed the spr/master/a1e3bceb branch from a603d52 to 099e299 Compare March 6, 2024 01:37
@tylerwowen tylerwowen force-pushed the spr/master/aa055770 branch from b2b1516 to 68d8174 Compare March 6, 2024 18:46
@tylerwowen tylerwowen force-pushed the spr/master/a1e3bceb branch 2 times, most recently from ff21841 to b516366 Compare March 6, 2024 19:01
@tylerwowen tylerwowen force-pushed the spr/master/aa055770 branch from 68d8174 to 8ed8e21 Compare March 6, 2024 19:01
@tylerwowen tylerwowen force-pushed the spr/master/a1e3bceb branch from b516366 to 7469673 Compare March 6, 2024 20:05
@tylerwowen tylerwowen force-pushed the spr/master/aa055770 branch 2 times, most recently from 21e8feb to dd595eb Compare March 7, 2024 18:33
@tylerwowen tylerwowen force-pushed the spr/master/a1e3bceb branch 2 times, most recently from 842d3f9 to cee8971 Compare March 9, 2024 00:32
@tylerwowen tylerwowen force-pushed the spr/master/aa055770 branch from dd595eb to 52edf2f Compare March 9, 2024 00:32
@tylerwowen tylerwowen force-pushed the spr/master/a1e3bceb branch from cee8971 to 980863b Compare March 12, 2024 19:01
@tylerwowen tylerwowen force-pushed the spr/master/aa055770 branch from 52edf2f to 7775f6c Compare March 12, 2024 19:02
@github-actions github-actions bot added the deploy-board Includes changes to deploy-board label Mar 12, 2024
@tylerwowen tylerwowen force-pushed the spr/master/a1e3bceb branch from 980863b to aa2e110 Compare March 12, 2024 23:34
@tylerwowen tylerwowen force-pushed the spr/master/aa055770 branch from 7775f6c to 675305a Compare March 12, 2024 23:34
@tylerwowen tylerwowen force-pushed the spr/master/a1e3bceb branch from aa2e110 to 1a6e3ab Compare March 13, 2024 00:21
@tylerwowen tylerwowen force-pushed the spr/master/aa055770 branch from 675305a to be65c92 Compare March 13, 2024 00:21
@github-actions github-actions bot removed the deploy-board Includes changes to deploy-board label Mar 13, 2024
@tylerwowen tylerwowen force-pushed the spr/master/a1e3bceb branch from 1a6e3ab to e3cc9ca Compare March 13, 2024 00:39
@tylerwowen tylerwowen force-pushed the spr/master/aa055770 branch from be65c92 to c3a59df Compare March 13, 2024 00:39
@tylerwowen tylerwowen force-pushed the spr/master/a1e3bceb branch 2 times, most recently from 010d774 to e5352c3 Compare March 26, 2024 16:54
@tylerwowen tylerwowen force-pushed the spr/master/aa055770 branch from 7c5beaf to 0bb44b3 Compare March 26, 2024 16:54
@tylerwowen tylerwowen force-pushed the spr/master/a1e3bceb branch from e5352c3 to 934a60d Compare March 26, 2024 23:57
@tylerwowen tylerwowen force-pushed the spr/master/aa055770 branch 2 times, most recently from f0092d1 to d884649 Compare March 27, 2024 00:33
@tylerwowen tylerwowen force-pushed the spr/master/a1e3bceb branch 2 times, most recently from 408a8e0 to e0ecd1e Compare March 27, 2024 01:25
@tylerwowen tylerwowen force-pushed the spr/master/aa055770 branch 2 times, most recently from 4227724 to b134354 Compare March 27, 2024 21:12
@tylerwowen tylerwowen force-pushed the spr/master/a1e3bceb branch 2 times, most recently from 15b412a to 776e9b7 Compare March 27, 2024 21:18
@tylerwowen tylerwowen force-pushed the spr/master/aa055770 branch from b134354 to 104f943 Compare March 27, 2024 21:18
@tylerwowen tylerwowen force-pushed the spr/master/a1e3bceb branch from 776e9b7 to b762162 Compare March 28, 2024 00:07
@tylerwowen tylerwowen force-pushed the spr/master/aa055770 branch from 104f943 to 22b9901 Compare March 28, 2024 00:07
@tylerwowen tylerwowen force-pushed the spr/master/a1e3bceb branch from b762162 to 319e4b3 Compare March 28, 2024 00:56
@tylerwowen tylerwowen force-pushed the spr/master/aa055770 branch 2 times, most recently from 3a1fcba to ddb9a63 Compare March 28, 2024 21:56
@tylerwowen tylerwowen force-pushed the spr/master/a1e3bceb branch from 319e4b3 to b027503 Compare March 28, 2024 21:56
@tylerwowen tylerwowen force-pushed the spr/master/aa055770 branch from ddb9a63 to 75e4155 Compare March 28, 2024 22:24
@tylerwowen tylerwowen force-pushed the spr/master/a1e3bceb branch from b027503 to b71e115 Compare March 28, 2024 22:24
@tylerwowen tylerwowen changed the base branch from spr/master/aa055770 to master April 16, 2024 22:58
@tylerwowen tylerwowen dismissed ntascii’s stale review April 16, 2024 22:58

The base branch was changed.

@tylerwowen tylerwowen requested a review from a team April 16, 2024 23:00
@tylerwowen
Copy link
Contributor Author

tylerwowen commented Apr 16, 2024 •
edited
Loading

Change base to master, as this no longer depends on the stack.

@tylerwowen
Modernize universal tests
c4dec74 
commit-id:a1e3bceb
@tylerwowen tylerwowen force-pushed the spr/master/a1e3bceb branch from 72283fa to c4dec74 Compare April 16, 2024 23:02
@tylerwowen tylerwowen merged commit 7dc8d75 into master Apr 16, 2024
2 checks passed
@tylerwowen tylerwowen deleted the spr/master/a1e3bceb branch April 16, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cjpilbdev Cjpilbdev Cjpilbdev approved these changes

@ntascii ntascii ntascii left review comments

Assignees
No one assigned
Labels
deploy-service Includes changes to deploy-service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tylerwowen @ntascii @Cjpilbdev