Remove duplicate deploy agent version #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two ways of determining the deploy agent version: 1. From the __version__ variables 2. From the config file Keep the __version__ variable and remove the config file version Also, clean up the test which was not testing a real scenario since the config is always passed in to the client
osoriano
force-pushed
the
osoriano/cleanup-deploy-agent-version
branch
from
08df988 to
e4f602e
Compare
robbintt
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There were two ways of determining the deploy agent version:
__version__variableKeep the
__version__variable and remove the config file versionAlso, clean up the test which was not testing a real scenario since the
config is always passed in to the client
Testing Done
Ran the updated code and ensured the agent version was still logged and sent in the ping request