Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ChannelOpen length validation #213

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

sirzooro
Copy link
Contributor

@sirzooro sirzooro commented Jul 6, 2024

Integer overflow in ChannelOpen length validation could cause crash.

Integer overflow in ChannelOpen length validation could cause crash.
Copy link

codecov bot commented Jul 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.88%. Comparing base (498e053) to head (fef1c40).

Files Patch % Lines
message_channel_open.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #213   +/-   ##
=======================================
  Coverage   69.88%   69.88%           
=======================================
  Files           4        4           
  Lines         259      259           
=======================================
  Hits          181      181           
  Misses         53       53           
  Partials       25       25           
Flag Coverage Δ
go 69.88% <0.00%> (ø)
wasm 69.88% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sirzooro sirzooro requested review from paulwe, edaniels and boks1971 July 6, 2024 10:14
@boks1971 boks1971 requested a review from cnderrauber July 6, 2024 12:05
Copy link
Contributor

@boks1971 boks1971 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sirzooro sirzooro merged commit 0246611 into pion:master Jul 6, 2024
13 of 14 checks passed
@sirzooro sirzooro deleted the fix_length_validation branch July 7, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants