Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestErrorsTemporary #615

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Fix TestErrorsTemporary #615

merged 1 commit into from
Mar 25, 2024

Conversation

enobufs
Copy link
Member

@enobufs enobufs commented Mar 25, 2024

Use a specific UDP port in TestErrorsTemporary to fix an error. See #614 for details.

Fixes #614

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.96%. Comparing base (38e39e4) to head (47a9103).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #615      +/-   ##
==========================================
+ Coverage   77.82%   77.96%   +0.13%     
==========================================
  Files         101      101              
  Lines        6444     6444              
==========================================
+ Hits         5015     5024       +9     
+ Misses       1056     1048       -8     
+ Partials      373      372       -1     
Flag Coverage Δ
go 77.98% <ø> (+0.13%) ⬆️
wasm 63.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@enobufs enobufs requested review from daenney and at-wat March 25, 2024 07:26
Copy link
Member

@at-wat at-wat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daenney daenney merged commit 8a93e0e into master Mar 25, 2024
15 checks passed
@daenney daenney deleted the issue-614 branch March 25, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestErrorsTemporary fails with "can't assign requested address"
3 participants