Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/nada interceptor integration #149

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mengelbart
Copy link
Contributor

This is based on #117 and adds a simple adapter to make the NADA implementation available to the generic CC interceptor.

This change adds the NADA congestion control implementation.
The binding to cc is left TODO.
@codecov
Copy link

codecov bot commented Jul 23, 2022

Codecov Report

Merging #149 (10f922b) into master (a82b843) will decrease coverage by 1.53%.
The diff coverage is 63.15%.

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
- Coverage   79.05%   77.52%   -1.54%     
==========================================
  Files          63       69       +6     
  Lines        3189     3550     +361     
==========================================
+ Hits         2521     2752     +231     
- Misses        555      677     +122     
- Partials      113      121       +8     
Flag Coverage Δ
go 77.52% <63.15%> (-1.54%) ⬇️
wasm ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/nada/bandwidth_estimator.go 0.00% <0.00%> (ø)
pkg/nada/report.go 0.00% <0.00%> (ø)
pkg/nada/packet_stream.go 65.75% <65.75%> (ø)
pkg/nada/receiver.go 93.67% <93.67%> (ø)
pkg/nada/sender.go 93.75% <93.75%> (ø)
pkg/nada/config.go 100.00% <100.00%> (ø)
pkg/gcc/kalman.go 100.00% <0.00%> (+5.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a82b843...10f922b. Read the comment docs.

Implements a simple adapter to satisfy the BandwidthEstimator interface
to allow using nada implementation in interceptor.
@mengelbart mengelbart force-pushed the feat/nada-interceptor-integration branch from 1ebbe49 to 10f922b Compare July 26, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants