Fix report timestamps #305
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not really a bug but annoying to receivers of our reports. If the ticker ticks, but then another packet is handled first, the timestamp of the report (from the ticker) will be before the receive timestamp of the last packet in the report. In that case, the report contains a 0x1FFF value to indicate that the packet was received after the report. However, we know the timestamp and can send it, if we take the timstamp after entering the case branch. At that time, it is guaranteed, that no additional packets can be added to the report.
mengelbart
force-pushed
the
fix-rfc8888-interceptor-timing
branch
from
4efe05c to
e1f3c06
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #305 +/- ##
==========================================
+ Coverage 71.31% 71.56% +0.25%
==========================================
Files 80 80
Lines 4483 4484 +1
==========================================
+ Hits 3197 3209 +12
+ Misses 1153 1145 -8
+ Partials 133 130 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JoeTurki
approved these changes
Jan 28, 2025
aalekseevx
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is not really a bug but annoying to receivers of our reports. If the ticker ticks, but then another packet is handled first, the timestamp of the report (from the ticker) will be before the receive timestamp of the last packet in the report. In that case, the report contains a 0x1FFF value to indicate that the packet was received after the report. However, we know the timestamp and can send it, if we take the timstamp after entering the case branch. At that time, it is guaranteed, that no additional packets can be added to the report.