Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make refactored BWE compatible with the old API #308

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mengelbart
Copy link
Contributor

Description

This makes the refactored BWE implementation compatible with the existing cc.Interceptor by implementing the cc.BandwidthEstimator interface and wrapping the new ccfb.Interceptor in the old cc.Interceptor. It does not (yet) implement pacing because that would cause nested pacing with the old implementation. Instead of merging this PR, I would actually prefer to remove the old API completely (by removing the gcc and cc packages).

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 60.70560% with 323 lines in your changes missing coverage. Please review.

Project coverage is 69.79%. Comparing base (c06f448) to head (9c58291).

Files with missing lines Patch % Lines
pkg/bwe/deprecated_bwe_api.go 0.00% 73 Missing ⚠️
pkg/bwe/kalman.go 0.00% 66 Missing ⚠️
pkg/bwe/delay_rate_controller.go 0.00% 57 Missing ⚠️
pkg/bwe/send_side_bwe.go 0.00% 28 Missing ⚠️
pkg/ccfb/interceptor.go 78.29% 22 Missing and 6 partials ⚠️
pkg/ccfb/twcc_receiver.go 70.83% 21 Missing ⚠️
pkg/bwe/state.go 70.27% 11 Missing ⚠️
pkg/cc/interceptor.go 0.00% 11 Missing ⚠️
pkg/bwe/usage.go 0.00% 10 Missing ⚠️
pkg/bwe/rate_controller.go 83.33% 8 Missing ⚠️
... and 4 more

❌ Your patch check has failed because the patch coverage (60.70%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
- Coverage   71.38%   69.79%   -1.60%     
==========================================
  Files          79       98      +19     
  Lines        4526     5340     +814     
==========================================
+ Hits         3231     3727     +496     
- Misses       1158     1469     +311     
- Partials      137      144       +7     
Flag Coverage Δ
go 69.79% <60.70%> (-1.47%) ⬇️
wasm ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant