Cleanup expired queries #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonVerkada
commented
Feb 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #175 +/- ##
==========================================
+ Coverage 64.08% 65.06% +0.98%
==========================================
Files 1 1
Lines 284 292 +8
==========================================
+ Hits 182 190 +8
Misses 72 72
Partials 30 30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
edaniels
approved these changes
Feb 7, 2024
| defer func() { | ||
| c.mu.Lock() | ||
| defer c.mu.Unlock() | ||
| for i := len(c.queries) - 1; i >= 0; i-- { |
There was a problem hiding this comment.
super-nit
Suggested change
| for i := len(c.queries) - 1; i >= 0; i-- { | |
| for i := 0; i < len(c.queries); i++ { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Defers a cleanup of the query entry after it expires, either by receiving an answer or when the context expires.
Reference issue
Fixes #174