Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reliable transmission for dcep message #139

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Conversation

enobufs
Copy link
Member

@enobufs enobufs commented Aug 10, 2020

Relates to #138

Description

Please see #138 for details.

This pull-request fixes a bug found during the trouble-shooting for #138. As the root cause of the hang addressed in #138 was not by this bug, but the current implementation obviously incorrect and this fix is necessary.

@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #139 into master will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
- Coverage   78.89%   78.83%   -0.06%     
==========================================
  Files          43       43              
  Lines        2800     2802       +2     
==========================================
  Hits         2209     2209              
- Misses        454      455       +1     
- Partials      137      138       +1     
Flag Coverage Δ
#go 78.83% <100.00%> (-0.06%) ⬇️
#wasm 69.91% <33.33%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
association.go 82.66% <100.00%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 248c545...0d754e0. Read the comment docs.

@enobufs enobufs requested review from at-wat and Sean-Der August 10, 2020 08:06
Copy link
Member

@at-wat at-wat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enobufs enobufs merged commit 10885f3 into master Aug 12, 2020
@Sean-Der Sean-Der deleted the 138-data-channel-hang branch September 10, 2020 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants