Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race in TestStreamClose introduced by #238 #243

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Fix race in TestStreamClose introduced by #238 #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ chenkaiC4 <[email protected]>
Hugo Arregui <[email protected]>
Hugo Arregui <[email protected]>
Jerko Steiner <[email protected]>
Jerry Tao <[email protected]>
John Bradley <[email protected]>
Konstantin Itskov <[email protected]>
Lukas Herman <[email protected]>
Expand Down
4 changes: 2 additions & 2 deletions vnet_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,8 +463,8 @@ func TestStreamClose(t *testing.T) {
log.Infof("server: received %d bytes (%d)", n, numServerReceived)
assert.Equal(t, 0, bytes.Compare(buf[:n], messages[numServerReceived]), "should receive HELLO")

_, err = stream.Write(buf[:n])
assert.NoError(t, err, "should succeed")
_, err2 := stream.Write(buf[:n])
assert.NoError(t, err2, "should succeed")

numServerReceived++
}
Expand Down