Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose error values #259

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Expose error values #259

merged 1 commit into from
Jan 13, 2023

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Jan 13, 2023

Make it possible to compare errors using errors.Is().

Reference issue

Related #251

@at-wat at-wat self-assigned this Jan 13, 2023
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 80.87% // Head: 80.87% // No change to project coverage 👍

Coverage data is based on head (be53505) compared to base (7ca78e8).
Patch coverage: 28.15% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #259   +/-   ##
=======================================
  Coverage   80.87%   80.87%           
=======================================
  Files          48       48           
  Lines        4032     4032           
=======================================
  Hits         3261     3261           
  Misses        629      629           
  Partials      142      142           
Flag Coverage Δ
go 80.87% <28.15%> (ø)
wasm 67.46% <19.41%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
chunk_abort.go 50.00% <0.00%> (ø)
chunk_cookie_ack.go 60.00% <0.00%> (ø)
chunk_cookie_echo.go 62.50% <0.00%> (ø)
chunk_error.go 50.00% <0.00%> (ø)
chunk_heartbeat.go 0.00% <0.00%> (ø)
chunk_heartbeat_ack.go 0.00% <0.00%> (ø)
chunk_init.go 36.36% <0.00%> (ø)
chunk_init_ack.go 37.50% <0.00%> (ø)
chunk_init_common.go 65.51% <0.00%> (ø)
chunk_selective_ack.go 66.66% <0.00%> (ø)
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Make it possible to compare errors using errors.Is().
@at-wat at-wat merged commit c18816d into master Jan 13, 2023
@at-wat at-wat deleted the expose-errors branch January 13, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants