AES_256 ICM #216
Closed
AES_256 ICM #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlexxIT do you mind rebasing your changes to the latest master branch? I would be happy to review and merge it :) |
|
Thanks. Sorry I didn't take the time to fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have implemented AES_256. This encryption used in many HomeKit Cameras. And this changes works fine with them. FFmpeg don't support this encryption. GStreamer support, but I haven't test it.
HomeKit Cameras allow to select encryption. AES_128 or AES_256. They prefer AES_256 by default.
I have tested both encryption with go2rtc project. But for now I left only the release version of the srtp library (only AES_128).