Fix several minor bugs #6009
Merged
Fix several minor bugs #6009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- A ship would not receive any equipment at all if its hull type was explicitly specified and the threat value passed was less than the hull threat. - To fix this, equipment which has no threat value is added to a ship regardless of the freeThreat metric. - Log a warning when attempting to outfit a ship with zero or negative freeThreat.
- Spawning a ship docked at a station can fail with no room available; return a nullable ship object for this method.
- When pressing the keybind to launch a missile, Ship:FireMissileAt was not checking the validity of a missile object
- Used old ui.iconButton() parameter list by accident
- PopulateStage1() was not being called for starports added at the end of the generation process, leading to orbital and surface starports without any population. - This manifested as an almost total lack of paintshops across the galaxy :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last one is the most interesting. Starports defined in custom system files exist when
PopulateStarSystemGenerator::PopulateStage1()is called, but randomly-generated starports are only added afterwards, inPopulateAddStations(). This lead to a lack of actual population onboard those stations, which at current only manifested in a lack of paintshops outside of fully-custom systems.