Fix: Use "--force" Option on Visual Studio Install #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise VS install fails in Windows 10
kiplingw
added
bug
dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1283 +/- ##
==========================================
+ Coverage 75.53% 75.95% +0.41%
==========================================
Files 58 60 +2
Lines 8859 9876 +1017
==========================================
+ Hits 6692 7501 +809
- Misses 2167 2375 +208 ☔ View full report in Codecov by Sentry. |
kiplingw
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Widows, the Pistache script winscripts/helpers/commonsetup.ps1 will install Visual Studio if VS is not installed already.
With this change, the command line option "--force" is included for the VS install command. Otherwise VS install may fail in Windows 10.