Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golang/go#57433
slices
in the standard library has only existed sincego1.21
. This is the reason for the errors in the recent tests.You have the following options:
golang.org/x/exp/slices
instead. This allows compatibility with go1.20 and below.This does not fix everything wrong with the tests. Most errors come from gocloud.dev/pubsub/drivertest.
e.g.
It looks like the issue has to do with t.Name() returning either the full or relative path as part of the name.
There are a lot more issues than $27 is worth lol. Just a fun rabbit hole I saw on Replit.