VariableEncodingNumBytes addition and non parser related files removal

Signed-off-by: Chinmay <[email protected]>
pixie-io · Nov 7, 2023 · 3216ad8 · 3216ad8
1 parent b742be2
commit 3216ad8
Show file tree

Hide file tree

Showing 12 changed files with 124 additions and 231 deletions.
diff --git a/src/stirling/binaries/stirling_wrapper.cc b/src/stirling/binaries/stirling_wrapper.cc
@@ -62,7 +62,7 @@ DEFINE_string(trace, "",
               "Dynamic trace to deploy. Either (1) the path to a file containing PxL or IR trace "
               "spec, or (2) <path to object file>:<symbol_name> for full-function tracing.");
 DEFINE_string(print_record_batches,
-              "http_events,mysql_events,pgsql_events,redis_events,cql_events,dns_events",
+              "http_events,mysql_events,pgsql_events,redis_events,cql_events,dns_events,mqtt_events",
               "Comma-separated list of tables to print.");
 DEFINE_bool(init_only, false, "If true, only runs the init phase and exits. For testing.");
 DEFINE_int32(timeout_secs, -1,

diff --git a/src/stirling/source_connectors/socket_tracer/bcc_bpf/BUILD.bazel b/src/stirling/source_connectors/socket_tracer/bcc_bpf/BUILD.bazel
@@ -82,7 +82,6 @@ pl_cc_test(
         "ENABLE_NATS_TRACING=true",
         "ENABLE_MONGO_TRACING=true",
         "ENABLE_AMQP_TRACING=true",
-        "ENABLE_MQTT_TRACING=true",
     ],
     deps = [
         "//src/stirling/bpf_tools/bcc_bpf:headers",

diff --git a/src/stirling/source_connectors/socket_tracer/bcc_bpf_intf/common.h b/src/stirling/source_connectors/socket_tracer/bcc_bpf_intf/common.h
@@ -51,7 +51,6 @@ enum traffic_protocol_t {
   kProtocolKafka = 10,
   kProtocolMux = 11,
   kProtocolAMQP = 12,
-  kProtocolMQTT = 13,
 // We use magic enum to iterate through protocols in C++ land,
 // and don't want the C-enum-size trick to show up there.
 #ifndef __cplusplus

diff --git a/src/stirling/source_connectors/socket_tracer/conn_tracker.cc b/src/stirling/source_connectors/socket_tracer/conn_tracker.cc
@@ -661,7 +661,6 @@ auto CreateTraceRoles() {
   res.Set(kProtocolKafka, {kRoleServer});
   res.Set(kProtocolMux, {kRoleServer});
   res.Set(kProtocolAMQP, {kRoleServer});
-  res.Set(kProtocolMQTT, {kRoleClient, kRoleServer});
 
   DCHECK(res.AreAllKeysSet());
   return res;

diff --git a/src/stirling/source_connectors/socket_tracer/data_stream.cc b/src/stirling/source_connectors/socket_tracer/data_stream.cc
@@ -204,8 +204,6 @@ template void DataStream::ProcessBytesToFrames<protocols::nats::Message, protoco
     message_type_t type, protocols::NoState* state);
 template void DataStream::ProcessBytesToFrames<protocols::amqp::Frame, protocols::NoState>(
     message_type_t type, protocols::NoState* state);
-template void DataStream::ProcessBytesToFrames<protocols::mqtt::Message, protocols::NoState>(
-    message_type_t type, protocols::NoState* state);
 void DataStream::Reset() {
   data_buffer_.Reset();
   has_new_events_ = false;

diff --git a/src/stirling/source_connectors/socket_tracer/mqtt_table.h b/src/stirling/source_connectors/socket_tracer/mqtt_table.h
diff --git a/src/stirling/source_connectors/socket_tracer/protocols/mqtt/BUILD.bazel b/src/stirling/source_connectors/socket_tracer/protocols/mqtt/BUILD.bazel
@@ -35,8 +35,6 @@ pl_cc_library(
         ],
     ),
     deps = [
-        "//src/common/json:cc_library",
-        "//src/common/zlib:cc_library",
         "//src/stirling/source_connectors/socket_tracer/protocols/common:cc_library",
         "//src/stirling/utils:cc_library",
     ],