Allow clang and gcc builds for `src/e2e_test/vizier/planner:planner_t…

…est` (#2077)

Summary: Allow clang and gcc builds for
`src/e2e_test/vizier/planner:planner_test`

As far as I can tell, there isn't a bazel config that matches the tags
of the `src/e2e_test/vizier/planner:planner_test` target. This change
removes the tag preventing clang builds since they appear to run without
problems. In addition to this, a `vispb` proto change was missing from
the earlier differential flamegraph work. This prevented the
`planner_test` from running properly (see comment for more details).

Relevant Issues: N/A

Type of change: /kind bugfix

Test Plan: Verified gcc and clang builds work
- [x] `bazel test --config clang
src/e2e_test/vizier/planner:planner_test` is successful
- [x] `bazel test -c opt --config gcc
src/e2e_test/vizier/planner:planner_test` is successful

---------

Signed-off-by: Dom Del Nano <[email protected]>

src/api/proto/vispb/vis.proto

@@ -458,4 +458,7 @@ message StackTraceFlameGraph {
   string node_column = 8;
   // The label for the percentage.
   string percentage_label = 9;
+  // The column containing the stacktrace's delta. This is only relevant for differential
+  // flamegraphs.
+  string difference_column = 10;
 }

src/common/exec/exec.cc

@@ -24,8 +24,14 @@
 
 namespace px {
 
+// GCC's ingnored-attribute warning is triggered without wrapping pclose. This is likely do to the
+// nonnull attribute.
+struct pclose_deleter {
+  void operator()(FILE* file) const { pclose(file); }
+};
+
 StatusOr<std::string> Exec(std::string cmd) {
-  std::unique_ptr<FILE, decltype(&pclose)> pipe(popen(cmd.c_str(), "r"), pclose);
+  std::unique_ptr<FILE, pclose_deleter> pipe(popen(cmd.c_str(), "r"));
   if (pipe == nullptr) {
     return error::Internal("popen() failed!");
   }

src/e2e_test/vizier/planner/BUILD.bazel

@@ -24,8 +24,6 @@ pl_go_test(
     ],
     tags = [
         "no_asan",
-        "no_gcc",
-        "no_libcpp",
         "no_msan",
         "no_tsan",
     ],