[chore] Update Typescript to 5.1 (#1478)

Summary: Updates the usual culprits to get TypeScript to v5.1. This change is [fairly minor](https://devblogs.microsoft.com/typescript/announcing-typescript-5-1/). Also fixes two typing issues that were not discovered before (the type checker has learned to detect more kinds of mistakes). Type of change: /kind cleanup Test Plan: `yarn; yarn lint; yarn test; yarn dev`. No new surprises. Signed-off-by: Nick Lanam <[email protected]>
pixie-io · Jun 13, 2023 · ac85eb2 · ac85eb2
1 parent f3849ef
commit ac85eb2
Show file tree

Hide file tree

Showing 9 changed files with 578 additions and 343 deletions.
diff --git a/.vscode/workspace.code-workspace b/.vscode/workspace.code-workspace
@@ -59,7 +59,7 @@
 			"**/.yarn": true,
 			"**/.pnp.*": true,
 		},
-		"typescript.tsdk": "src/ui/.yarn/sdks/typescript/lib",
+		"typescript.tsdk": "@pixielabs/ui/.yarn/sdks/typescript/lib",
 		"typescript.enablePromptUseWorkspaceTsdk": true
 	}
 }
diff --git a/src/ui/.yarn/releases/yarn-3.5.1.cjs → src/ui/.yarn/releases/yarn-3.6.0.cjs b/src/ui/.yarn/releases/yarn-3.5.1.cjs → src/ui/.yarn/releases/yarn-3.6.0.cjs
diff --git a/src/ui/.yarn/sdks/eslint/package.json b/src/ui/.yarn/sdks/eslint/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint",
-  "version": "8.41.0-sdk",
+  "version": "8.42.0-sdk",
   "main": "./lib/api.js",
   "type": "commonjs"
 }
diff --git a/src/ui/.yarn/sdks/typescript/package.json b/src/ui/.yarn/sdks/typescript/package.json
@@ -1,6 +1,6 @@
 {
   "name": "typescript",
-  "version": "5.0.4-sdk",
+  "version": "5.1.3-sdk",
   "main": "./lib/typescript.js",
   "type": "commonjs"
 }
diff --git a/src/ui/.yarnrc.yml b/src/ui/.yarnrc.yml
@@ -4,4 +4,4 @@ plugins:
 - path: .yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs
   spec: "@yarnpkg/plugin-interactive-tools"
 
-yarnPath: .yarn/releases/yarn-3.5.1.cjs
+yarnPath: .yarn/releases/yarn-3.6.0.cjs
diff --git a/src/ui/package.json b/src/ui/package.json
@@ -27,8 +27,8 @@
     "@types/react-table": "^7.7.1",
     "@types/react-window": "^1.8.3",
     "@types/segment-analytics": "^0.0.32",
-    "@typescript-eslint/eslint-plugin": "^5.59.8",
-    "@typescript-eslint/parser": "^5.59.8",
+    "@typescript-eslint/eslint-plugin": "^5.59.11",
+    "@typescript-eslint/parser": "^5.59.11",
     "@welldone-software/why-did-you-render": "^4.3.1",
     "@yarnpkg/pnpify": "^3.1.0",
     "archiver": "^5.0.2",
@@ -39,12 +39,12 @@
     "concurrently": "^6.2.0",
     "css-loader": "^5.2.6",
     "cypress": "^9.3.0",
-    "esbuild": "^0.17.19",
+    "esbuild": "^0.18.2",
     "esbuild-jest": "^0.5.0",
     "esbuild-loader": "^3.0.1",
-    "eslint": "^8.41.0",
-    "eslint-config-airbnb-typescript": "^16.1.0",
-    "eslint-import-resolver-node": "^0.3.6",
+    "eslint": "^8.42.0",
+    "eslint-config-airbnb-typescript": "^17.0.0",
+    "eslint-import-resolver-node": "^0.3.7",
     "eslint-import-resolver-typescript": "^3.5.5",
     "eslint-plugin-cypress": "^2.12.1",
     "eslint-plugin-import": "^2.27.5",
@@ -69,12 +69,12 @@
     "regenerator-runtime": "^0.13.7",
     "style-loader": "^2.0.0",
     "svg-url-loader": "^6.0.0",
-    "typescript": "^5.0.4",
+    "typescript": "^5.1.3",
     "url-loader": "^4.1.1",
-    "webpack": "^5.84.1",
-    "webpack-bundle-analyzer": "^4.8.0",
-    "webpack-cli": "^5.1.1",
-    "webpack-dev-server": "^4.15.0",
+    "webpack": "^5.86.0",
+    "webpack-bundle-analyzer": "^4.9.0",
+    "webpack-cli": "^5.1.4",
+    "webpack-dev-server": "^4.15.1",
     "yaml": "^1.6.0"
   },
   "license": "SEE LICENSE IN LICENSE.txt",
@@ -164,5 +164,6 @@
   "resolutions": {
     "@types/react": "^18.0.9",
     "multicast-dns": "7.2.3"
-  }
+  },
+  "packageManager": "[email protected]"
 }
diff --git a/src/ui/src/components/command-palette/providers/script/missing-script-provider.tsx b/src/ui/src/components/command-palette/providers/script/missing-script-provider.tsx
@@ -260,7 +260,7 @@ export const useMissingScriptProvider: CommandProvider = () => {
   const { setScriptAndArgs } = React.useContext(ScriptContext);
   const { setOpen } = React.useContext(CommandPaletteContext);
 
-  const [promises, setPromises] = React.useState<CancellablePromise[]>([]);
+  const [promises, setPromises] = React.useState<CancellablePromise<DecoratedCompletion[]>[]>([]);
   const [state, setState] = React.useState<CommandProviderState>(DEFAULT);
 
   const invoke = React.useCallback((

diff --git a/src/ui/src/components/version-info/version-info.tsx b/src/ui/src/components/version-info/version-info.tsx
@@ -23,6 +23,6 @@ import { Tooltip } from '@mui/material';
 import { PIXIE_CLOUD_VERSION } from 'app/utils/env';
 
 export const VersionInfo = React.memo(() => (
-  <Tooltip title={PIXIE_CLOUD_VERSION.tag}><span>Built {PIXIE_CLOUD_VERSION.date}</span></Tooltip>
+  <Tooltip title={PIXIE_CLOUD_VERSION.tag ?? ''}><span>Built {PIXIE_CLOUD_VERSION.date}</span></Tooltip>
 ));
 VersionInfo.displayName = 'VersionInfo';