Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Parse incomplete chunks 3/9] Add ChunkInfo metadata to DS buffer to record (un)filled gap locations #1788

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

benkilimnik
Copy link
Member

@benkilimnik benkilimnik commented Nov 29, 2023

Summary: Adds metadata to the always_contiguous_data_stream_buffer to keep track of gap and filler locations. This forms the basis of tracking the number of bytes rendered unparseable due to the presence of a gap (i.e. the bytes cut off before the gap). It is also used to lazily parse as far as possible up to the gap in a future PR.

A TODO is added to the lazy_contiguous implementation in case we switch to that at some point in the future.

Note that this PR relies on changes introduced in #1786 and #1787.

Type of change: /kind feature

Test Plan: Test cases added to data_stream_buffer_test.cc

Additional Context: #1755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant