Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade go dependencies #1

Closed
wants to merge 2 commits into from
Closed

Upgrade go dependencies #1

wants to merge 2 commits into from

Conversation

ddelnano
Copy link
Member

@ddelnano ddelnano commented Nov 22, 2023 •
edited
Loading

Summary: Update pxapi.go to address security vulnerabilities

pixie-io/pixie#1780 has been created on the monorepo side to propagate this change there.

Relevant Issues: newrelic/newrelic-pixie-integration#143

Type of change: /kind dependencies

Test Plan: Ran all of the examples except for the standalone pem and verified they were successful

api-key example 
ddelnano@vigenere:~/code/pxapi.go (ddelnano/upgrade-go-deps) $ go run examples/api_key_example/api_key_example.go
Using new client
Created API key: <api key>
basic example 
ddelnano@vigenere:~/code/pxapi.go (ddelnano/upgrade-go-deps) $ go run examples/basic_example/example.go
Using new client
Running on Cluster: 9f0e5456-dd33-4b2a-91ac-e480ea7b1aa5
Running script
00000003-0000-1d7a-0000-00000000b87d / 10.119.1.1 GET
00000003-0000-1d7a-0000-00000000b87d / 10.119.1.1 GET
00000003-0000-0970-0000-000000000692 /healthz 127.0.0.1 GET
00000003-0000-16a1-0000-00000000a286 /healthz 10.119.1.1 GET
00000003-0000-16a1-0000-00000000a286 /healthz 10.119.1.1 GET
00000003-0000-169e-0000-00000000a286 /healthz 10.119.1.1 GET
00000003-0000-169e-0000-00000000a286 /healthz 10.119.1.1 GET
00000003-0000-0f64-0000-0000000073ae /healthz 10.119.1.1 GET
00000003-0000-109a-0000-0000000075f7 /healthcheck/kubedns 10.119.1.1 GET
00000003-0000-0f97-0000-0000000073dd /readiness 10.119.1.1 GET
Execution Time: 4.379ms
Bytes received: 556
encryption example 
ddelnano@vigenere:~/code/pxapi.go (ddelnano/upgrade-go-deps) $ go run examples/encryption_example/example.go
Using new client
Running on Cluster: 9f0e5456-dd33-4b2a-91ac-e480ea7b1aa5
Running script
00000003-0000-1d7a-0000-00000000b87d / 10.119.1.1 GET
00000003-0000-1d7a-0000-00000000b87d / 10.119.1.1 GET
00000003-0000-0970-0000-000000000692 /healthz 127.0.0.1 GET
00000003-0000-16a1-0000-00000000a286 /healthz 10.119.1.1 GET
00000003-0000-16a1-0000-00000000a286 /healthz 10.119.1.1 GET
00000003-0000-169e-0000-00000000a286 /healthz 10.119.1.1 GET
00000003-0000-169e-0000-00000000a286 /healthz 10.119.1.1 GET
00000003-0000-0f64-0000-0000000073ae /healthz 10.119.1.1 GET
00000003-0000-109a-0000-0000000075f7 /healthcheck/kubedns 10.119.1.1 GET
00000003-0000-0f97-0000-0000000073dd /readiness 10.119.1.1 GET
Execution Time: 2.526ms
Bytes received: 556
deploy-key example 
ddelnano@vigenere:~/code/pxapi.go (ddelnano/upgrade-go-deps) $ go run examples/deploykey_example/example.go
Using new client
Created deploy key: &DeploymentKey{ID:&uuidpb.UUID{HighBits:XXXXX,LowBits:XXXX,},Key:<XXXXX>,CreatedAt:2023-11-22T13:17:54.179408Z,Desc:,OrgID:nil,UserID:nil,}
mux example 
ddelnano@vigenere:~/code/pxapi.go (ddelnano/upgrade-go-deps) $ go run examples/example_mux/example.go
Using new client
Running on Cluster: 9f0e5456-dd33-4b2a-91ac-e480ea7b1aa5
{"_tableName_":"http_as_json","upid":"00000003-0000-1d7a-0000-00000000b87d","req_path":"/","remote_addr":"10.119.1.1","req_method":"GET"}
{"_tableName_":"http_as_json","upid":"00000003-0000-1d7a-0000-00000000b87d","req_path":"/","remote_addr":"10.119.1.1","req_method":"GET"}
{"_tableName_":"http_as_json","upid":"00000003-0000-0970-0000-000000000692","req_path":"/healthz","remote_addr":"127.0.0.1","req_method":"GET"}
{"_tableName_":"http_as_json","upid":"00000003-0000-16a1-0000-00000000a286","req_path":"/healthz","remote_addr":"10.119.1.1","req_method":"GET"}
{"_tableName_":"http_as_json","upid":"00000003-0000-16a1-0000-00000000a286","req_path":"/healthz","remote_addr":"10.119.1.1","req_method":"GET"}
{"_tableName_":"http_as_json","upid":"00000003-0000-169e-0000-00000000a286","req_path":"/healthz","remote_addr":"10.119.1.1","req_method":"GET"}
{"_tableName_":"http_as_json","upid":"00000003-0000-169e-0000-00000000a286","req_path":"/healthz","remote_addr":"10.119.1.1","req_method":"GET"}
{"_tableName_":"http_as_json","upid":"00000003-0000-0f64-0000-0000000073ae","req_path":"/healthz","remote_addr":"10.119.1.1","req_method":"GET"}
{"_tableName_":"http_as_json","upid":"00000003-0000-109a-0000-0000000075f7","req_path":"/healthcheck/kubedns","remote_addr":"10.119.1.1","req_method":"GET"}
{"_tableName_":"http_as_json","upid":"00000003-0000-0f97-0000-0000000073dd","req_path":"/readiness","remote_addr":"10.119.1.1","req_method":"GET"}
Table: http_as_table
  UPID                                  REQ PATH              REMOTE ADDR  REQ METHOD
  00000003-0000-1d7a-0000-00000000b87d  /                     10.119.1.1   GET
  00000003-0000-1d7a-0000-00000000b87d  /                     10.119.1.1   GET
  00000003-0000-0970-0000-000000000692  /healthz              127.0.0.1    GET
  00000003-0000-16a1-0000-00000000a286  /healthz              10.119.1.1   GET
  00000003-0000-16a1-0000-00000000a286  /healthz              10.119.1.1   GET
  00000003-0000-169e-0000-00000000a286  /healthz              10.119.1.1   GET
  00000003-0000-169e-0000-00000000a286  /healthz              10.119.1.1   GET
  00000003-0000-0f64-0000-0000000073ae  /healthz              10.119.1.1   GET
  00000003-0000-109a-0000-0000000075f7  /healthcheck/kubedns  10.119.1.1   GET
  00000003-0000-0f97-0000-0000000073dd  /readiness            10.119.1.1   GET
Execution Time: 2.874ms
Bytes received: 1112
streaming example 
ddelnano@vigenere:~/code/pxapi.go (ddelnano/upgrade-go-deps) $ go run examples/streaming_example/example.go
Using new client
Running on Cluster: 9f0e5456-dd33-4b2a-91ac-e480ea7b1aa5
Running script
200 /healthz
200 /
200 /
200 /healthz
200 /healthz
200 /readiness
200 /healthcheck/kubedns
200 /healthcheck/dnsmasq
200 /metrics
200 /-/ready
200 /-/healthy
200 /-/ready
200 /-/healthy
200 /
200 /healthz
200 /
200 /
200 /healthz
200 /health-check
200 /healthz
200 /healthcheck/kubedns
200 /readiness
200 /healthcheck/dnsmasq
200 /metrics
200 /-/ready
200 /-/healthy
200 /-/ready
200 /-/healthy
200 /healthz
200 /
200 /
200 /healthz
200 /healthz
200 /healthcheck/kubedns
200 /readiness
200 /healthcheck/dnsmasq
200 /metrics
200 /-/healthy
200 /-/ready
200 /-/healthy
200 /-/ready
200 /
200 /healthz
200 /
200 /
200 /healthz
200 /health-check
200 /healthz
200 /healthcheck/kubedns
200 /readiness
200 /healthcheck/dnsmasq

@ddelnano ddelnano mentioned this pull request Nov 22, 2023
Merged
vihangm pushed a commit to pixie-io/pixie that referenced this pull request Nov 25, 2023
@ddelnano
Update pxapi go deps in line with latest pxapi repo changes (#1780)
dffdb3b 
Summary: Update pxapi go deps in line with latest pxapi repo changes

This propagates the changes to the pxapi repo to upgrade its
dependencies to address grpc vulnerabilities

Relevant Issues: N/A

Type of change: /kind dependencies

Test Plan: Verified that the pxapi go changes worked with the examples
in the repo (see pixie-io/pxapi.go#1 for more
details)

Signed-off-by: Dom Del Nano <[email protected]>
copybaranaut pushed a commit that referenced this pull request Nov 25, 2023
@ddelnano @copybaranaut
Update pxapi go deps in line with latest pxapi repo changes (#1780)
6fec9b3 
Summary: Update pxapi go deps in line with latest pxapi repo changes

This propagates the changes to the pxapi repo to upgrade its
dependencies to address grpc vulnerabilities

Relevant Issues: N/A

Type of change: /kind dependencies

Test Plan: Verified that the pxapi go changes worked with the examples
in the repo (see #1 for more
details)

Signed-off-by: Dom Del Nano <[email protected]>
GitOrigin-RevId: dffdb3b681f35583cc3749ca2ecb56593c29f752
@ddelnano
Copy link
Member Author

Closing this since it was completed in pixie-io/pixie#1780.

@ddelnano ddelnano closed this Nov 27, 2023
@ddelnano ddelnano deleted the ddelnano/upgrade-go-deps branch November 27, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ddelnano