pjsua2: add destroyPlayer to AudioMediaPlayer #3789
Conversation
|
|
|
This looks like a clear violation of Object Oriented Programming. You're not supposed to destroy something that belongs to another object. |
|
|
||
| #if ((defined(_MSVC_LANG) && _MSVC_LANG <= 199711L) || __cplusplus <= 199711L) | ||
| /* C++98 does not have Vector::data() */ | ||
| if (frame->size > 0) | ||
| pj_memcpy(frame->buf, &frame_.buf[0], frame->size); | ||
| #else | ||
| /* Newer than C++98 */ | ||
| /* Newer than C++98 */ | ||
| pj_memcpy(frame->buf, frame_.buf.data(), frame->size); | ||
| #endif | ||
| #endif |
There was a problem hiding this comment.
Note: these lines only changes CRLF to LF
|
Fixed. Also updated comment to specify use with other languages, like Golang, to not wait for GC to acts. |
|
It's essentially the same as what the class destructor does. I can understand though why this is needed, especially for GC languages such as Java, Python, C#, when you may need to release resources immediately without having to wait for GC to kick in or manually forcing GC (in C#, like you described, this mechanism will be similar to implementing Unfortunately, in my opinion, it's unlikely to be merged to the master branch since the implementation is only limited to AudioMediaPlayer, while if we really do need this feature, it probably needs to be more comprehensive than this, i.e.:
|
|
In C# or Java not problem because the Dispose, but in Go I need to wait the GC. You are correct about expand more this, I only covers my use case. And about race conditions, GC will be triggered only if not referenced, so, calling a virtual destructor like this cannot interfere with GC, because to be called the object need to be referenced. I think this should be in dev side. |
With this, the dev can destroy a specific player when needed without wait GC in some languages with not Dispose