Include PJSIP module data in cloning pjsip_rx_data #3797
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauwming
approved these changes
Dec 5, 2023
trengginas
approved these changes
Dec 6, 2023
|
Not sure if this should be merged, as copying module data can be risky. For example invite session uses module data to store SDP info, many parts of the SDP info refer to rdata buffer, so copying the invite session's module data (containing SDP info pointing to original rdata buffer) can be harmful as the original rdata may be invalid soon. |
|
Ah...wrote before I found your comment. So, I guess it probably wont be merged then. |
|
Yes, if it doesn't help solve the issue, IMO it's better not to merge it and close the PR. We can always revisit/reopen later when needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
pjsip_rx_data_clone()always excludes PJSIP module data field (i.e:endpt_info/mod_data) in cloningpjsip_rx_data. This PR introduce a new flagPJSIP_RX_DATA_CLONE_ENDPT_INFOto also copy that field.