Fixed issues when adding new media and deinitializing media #3821
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several issues when adding new media, which need to be fixed:
inactive
.This is because we currently don't set media direction for media reinitialization.
param->dir
when adding video usingpjsua_call_set_vid_strm(call_id, PJSUA_CALL_VID_STRM_ADD, param)
.There's also another issue with double media deinitialization:
pjsua_call_hangup_all()
andpjsua_media_channel_deinit()
will deinitialise the media twice.